[Nepomuk] Review Request: Fix crashes due to using the same QUrls in multiple threads.

[David Faure]

> On July 25, 2012, 9:26 a.m., Sebastian Trueg wrote:
> > Well, this is very unfortuanate. It even makes me think whether we should go back to the old version which returned QUrl::fromEncoded in every function... I only introduced the global static for performance reasons.
> > Anyway, I am fine with the patch if you add a big comment explaining the problem.
> 
> Vishesh Handa wrote:
>     Sebastian, I think you'll have to release a bug fix version of Soprano with this patch.

fromEncoded means parsing -every single time-, so at least this version (parsing once per thread) is a lot faster already.

Committed with a comment, and a Qt version check so that with Qt5 we automatically go back to a simple global static.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105621/#review16358
-----------------------------------------------------------


On July 25, 2012, 8:58 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105621/
> -----------------------------------------------------------
> 
> (Updated July 25, 2012, 8:58 a.m.)
> 
> 
> Review request for Nepomuk and Release Team.
> 
> 
> Description
> -------
> 
> Fix crashes due to using the same QUrls in multiple threads.
> 
> I'm also working on a Qt4 QUrl fix (using QMutex), and this is already
> fixed in Qt5 (the rewrite does no more delayed parsing), but let's make
> our software stable as soon as possible, too, by using QThreadStorage
> to avoid the race.
> 
> 
> Diffs
> -----
> 
>   tools/onto2vocabularyclass.cpp 9a5a92b6210e695a6ad3cba9afe9aa1341759fc5 
> 
> Diff: http://git.reviewboard.kde.org/r/105621/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120725/cb49d251/attachment.html>