[Nepomuk] Review Request: ResourceData::store - Give the correct type to createResource()

Sebastian Trueg sebastian at trueg.de
Wed Jul 25 08:57:11 UTC 2012



> On July 25, 2012, 8:47 a.m., Sebastian Trueg wrote:
> > How about doing this in the DMS instead?
> 
> Vishesh Handa wrote:
>     Should I do it right now? Or in another commit?
>     
>     There is a TODO: move this to the DMS

There is no time like the present. :D
Do it whenever you want. I did not see the TODO.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105712/#review16347
-----------------------------------------------------------


On July 24, 2012, 5:57 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105712/
> -----------------------------------------------------------
> 
> (Updated July 24, 2012, 5:57 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     Give nfo:Folder if it is a directory.
>     Give nof:FileDataObject if it is a file.
>     Give rdfs:Resource if nothing else has been specified.
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/resource/resourcedata.cpp c1143e8 
> 
> Diff: http://git.reviewboard.kde.org/r/105712/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120725/e07aa69c/attachment.html>


More information about the Nepomuk mailing list