[Nepomuk] Review Request: ResourceWatcher: Send the values as QVariants not QDBusVariants

[Sebastian Trueg]

> On July 25, 2012, 8:44 a.m., Sebastian Trueg wrote:
> > services/storage/resourcewatchermanager.cpp, line 46
> > <http://git.reviewboard.kde.org/r/105709/diff/1/?file=74674#file74674line46>
> >
> >     This is directly related to the client RW review I think: it is very hard to determine if the value is a URl on the other end.
> 
> Vishesh Handa wrote:
>     I think we can use the standard - if is has a scheme, then it's a url?

Well, that is not very future-proof. Some properties may link to URIs that do not have a scheme like di:... or urn:... or whatever.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105709/#review16344
-----------------------------------------------------------


On July 24, 2012, 5:57 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105709/
> -----------------------------------------------------------
> 
> (Updated July 24, 2012, 5:57 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     I have no idea why we chose to send them as QDBusVariants, but it causes
>     problems in extracting the data at the other end.
>     
>     Also pass resources as strings, and not QUrls. DBus does not natively
>     support QUrls and passes them as -
>     
>      struct { string nepomuk:/res/.. }
>     
>     instead of just 'string nepomuk:/res/..'
> 
> 
> Diffs
> -----
> 
>   services/storage/resourcewatchermanager.cpp 80883a4 
> 
> Diff: http://git.reviewboard.kde.org/r/105709/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120725/8d9a602b/attachment-0001.html>