[Nepomuk] Review Request: SimpleResource: Avoid duplicates when adding another PropertyHash

Sebastian Trueg sebastian at trueg.de
Wed Jul 25 08:50:53 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105718/#review16352
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Trueg


On July 24, 2012, 5:57 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105718/
> -----------------------------------------------------------
> 
> (Updated July 24, 2012, 5:57 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> We need to add each (key, value) pair separately, so as to avoid
> duplicates. A QMultiHash can contain the same (key, value) pair
> multiples times.
>     
> This fixes SimpleResourceSubsystemTest::testSimpleResourceGraphAdd
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/datamanagement/simpleresource.cpp 7357d96 
> 
> Diff: http://git.reviewboard.kde.org/r/105718/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120725/b56b249e/attachment.html>


More information about the Nepomuk mailing list