[Nepomuk] Review Request: ResourceWatcher: Convert uris to QUrls

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105710/#review16342
-----------------------------------------------------------



libnepomukcore/datamanagement/resourcewatcher.cpp
<http://git.reviewboard.kde.org/r/105710/#comment12824>

    Better make this a small method in an anonymous namespace to avoid code duplication.



libnepomukcore/datamanagement/resourcewatcher.cpp
<http://git.reviewboard.kde.org/r/105710/#comment12825>

    What if the value of nie:url is changed? Then the value does not start with "nepomuk:/" but it is still a url.
    Maybe it would be better to check the property instead or add a separate signal for url values.


- Sebastian Trueg


On July 24, 2012, 5:57 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105710/
> -----------------------------------------------------------
> 
> (Updated July 24, 2012, 5:57 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> uris are received as strings, but they should be saved as QUrls in the
> QVariant.
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/datamanagement/resourcewatcher.cpp 0b08c73 
> 
> Diff: http://git.reviewboard.kde.org/r/105710/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120725/77a78cfa/attachment.html>