[Nepomuk] Review Request: ClassAndPropertyTree - Always make sure a url has a scheme
Sebastian Trueg
sebastian at trueg.de
Wed Jul 25 08:36:22 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105705/#review16339
-----------------------------------------------------------
services/storage/classandpropertytree.cpp
<http://git.reviewboard.kde.org/r/105705/#comment12822>
Below we actually check if the file exists. Does that make sense here, too? Or could there be calls on files that have been removed in the meantime?
- Sebastian Trueg
On July 24, 2012, 5:57 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105705/
> -----------------------------------------------------------
>
> (Updated July 24, 2012, 5:57 p.m.)
>
>
> Review request for Nepomuk and Sebastian Trueg.
>
>
> Description
> -------
>
> In variantListToNodeSet, make sure the urls have a scheme of file, if no
> scheme has been provided.
>
> Special check for blank nodes used in storeResources
>
>
> Diffs
> -----
>
> services/storage/classandpropertytree.cpp 4c730bf
>
> Diff: http://git.reviewboard.kde.org/r/105705/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120725/7129f841/attachment.html>
More information about the Nepomuk
mailing list