[Nepomuk] Review Request: ResourceWatcher: Send the values as QVariants not QDBusVariants

Vishesh Handa me at vhanda.in
Tue Jul 24 17:57:06 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105709/
-----------------------------------------------------------

Review request for Nepomuk and Sebastian Trueg.


Description
-------

    I have no idea why we chose to send them as QDBusVariants, but it causes
    problems in extracting the data at the other end.
    
    Also pass resources as strings, and not QUrls. DBus does not natively
    support QUrls and passes them as -
    
     struct { string nepomuk:/res/.. }
    
    instead of just 'string nepomuk:/res/..'


Diffs
-----

  services/storage/resourcewatchermanager.cpp 80883a4 

Diff: http://git.reviewboard.kde.org/r/105709/diff/


Testing
-------


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120724/197af64f/attachment.html>


More information about the Nepomuk mailing list