[Nepomuk] Review Request: Disable Query excerpts by default

Vishesh Handa me at vhanda.in
Tue Jul 24 06:36:03 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105065/
-----------------------------------------------------------

(Updated July 24, 2012, 6:36 a.m.)


Review request for Nepomuk and Sebastian Trueg.


Description
-------

If people want them, they should enable them. There is no advantage of providing them by default. Specially since no one seems to be using them. It also complicates the queries when you're trying to debug stuff. 
 
Also, this breaks the existing API a little bit. However, since no one has packaged Nepomuk2 so far, I'm allowed to break stuff.


Diffs
-----

  libnepomukcore/query/query.h f4360b0 
  libnepomukcore/query/query.cpp d67b6ce 
  libnepomukcore/query/queryserializer.cpp 0d8bc7e 
  libnepomukcore/test/queryserializertest.cpp ccc8af6 
  libnepomukcore/test/querytest.cpp 2a8f685 

Diff: http://git.reviewboard.kde.org/r/105065/diff/


Testing
-------

Not tested. This also breaks almost all the tests in querytest. I'm waiting to see if trueg is okay with this patch.


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120724/867e0cc0/attachment-0001.html>


More information about the Nepomuk mailing list