[Nepomuk] Review Request: Nepomuk Test Library and tests

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105597/#review16069
-----------------------------------------------------------

Ship it!


This looks really good. Nice work, Vishesh. :)


autotests/CMakeLists.txt
<http://git.reviewboard.kde.org/r/105597/#comment12642>

    does this mean the tests install files?



autotests/README
<http://git.reviewboard.kde.org/r/105597/#comment12643>

    Would it be hard to add an environment check to avoid loosing any data?



autotests/lib/CMakeLists.txt
<http://git.reviewboard.kde.org/r/105597/#comment12644>

    Why do you install the test?


- Sebastian Trueg


On July 16, 2012, 6:57 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105597/
> -----------------------------------------------------------
> 
> (Updated July 16, 2012, 6:57 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> This is the Nepomuk Test Framework which I had described months ago over here - http://vhanda.in/blog/2012/03/nepomuk-test-framework/
> 
> It is currently in the testLibrary branch in nepomuk-core. This is a diff of testLibrary against KDE/4.9.
> 
> The testlib creates mock kde and dbus sessions and then starts Nepomuk. It waits till the nepomuk query service has been started and it then runs the tests. Once the tests have run, it shuts down the mock kde sessions, and destroys the temporary folder in which it was created.
> 
> The patch also contains very detailed tests for the Resource class. Most of the tests fail :) It seems like I have a lot of work to do.
> 
> I would like to merge this into KDE/4.9. I hope no one has any objections.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4d5ae3f 
>   autotests/CMakeLists.txt PRE-CREATION 
>   autotests/README PRE-CREATION 
>   autotests/lib/CMakeLists.txt PRE-CREATION 
>   autotests/lib/NepomukTestLibMacros.cmake.in PRE-CREATION 
>   autotests/lib/nepomukserverrc.in PRE-CREATION 
>   autotests/lib/nepomuktest_export.h PRE-CREATION 
>   autotests/lib/testbase.h PRE-CREATION 
>   autotests/lib/testbase.cpp PRE-CREATION 
>   autotests/lib/tools/CMakeLists.txt PRE-CREATION 
>   autotests/lib/tools/runNepomukTest.sh.in PRE-CREATION 
>   autotests/lib/tools/run_in_new_dbus_session.sh PRE-CREATION 
>   autotests/lib/tools/with-nepomuk-sandbox.sh.in PRE-CREATION 
>   autotests/test/CMakeLists.txt PRE-CREATION 
>   autotests/test/resourcetests.h PRE-CREATION 
>   autotests/test/resourcetests.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105597/diff/
> 
> 
> Testing
> -------
> 
> Yes. The tests have been tested.
> 
> If you want to run the tests please run them via 'ctest -VV'. Do not run the test executables manually. This would not result in the test environment being setup, and a new virtuoso database would be not be created. This would result in ALL your Nepomuk data being deleted at the end of the test.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120718/bfa85465/attachment.html>