[Nepomuk] Review Request: Avoid automatic clearing of the ResourceManager cache

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105516/#review15682
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Trueg


On July 11, 2012, 4:01 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105516/
> -----------------------------------------------------------
> 
> (Updated July 11, 2012, 4:01 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> Avoid automatic clearing of the ResourceManager cache
> 
> The current limit was hard coded and wasn't based on any real world
> usage. With the new dolphin features and amarok being ported to Nepomuk,
> it is very common to have more than 10k resources.
> 
> When one overcomes that number, then for each new Resource the entire
> kickoff list is searched in an attempt to find ResourceData* which are
> no longer being used.
> 
> Instead, now whenever a ResourceData* is no longer being used, it is
> simply deleted.
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/resource/resourcedata.cpp e19b4bdcd3bea11c32673d13df665cff24783e06 
>   libnepomukcore/resource/resourcemanager.cpp b467c048d7dc5d0cdcae383adb43a0434908f3a8 
>   libnepomukcore/resource/resourcemanager_p.h fc9335cd4fa63eb2bbf971aa1bd7d1edb93f5be9 
> 
> Diff: http://git.reviewboard.kde.org/r/105516/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120711/47a78a53/attachment.html>