[Nepomuk] Review Request: Allow synchronous execution of queries

[Vishesh Handa]

> On July 11, 2012, 3:53 p.m., Sebastian Trueg wrote:
> > Except for the missing docs it looks good.

Should I push this into KDE/4.9? I don't think I should.

Also, if I'm pushing this into master, then can I deprecate the syncQuery* functions in the QueryServiceClient? Or should I just implement them using the ResultIterator?


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105287/#review15680
-----------------------------------------------------------


On July 11, 2012, 3:38 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105287/
> -----------------------------------------------------------
> 
> (Updated July 11, 2012, 3:38 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> Allow synchronous execution of queries
> 
> This is done by returning a Nepomuk::Query::ResultIterator, and
> allows the user to control the execution of the query with the
> iterator.
> 
> This lets us move away from Soprano. Plus, this avoids
> code duplication as this code is being duplicated in both the
> query service and the kioslave.
> 
> 
> Diffs
> -----
> 
>   includes/CMakeLists.txt 3e07f83 
>   includes/Query/ResultIterator PRE-CREATION 
>   libnepomukcore/CMakeLists.txt 066c898 
>   libnepomukcore/query/resultiterator.h PRE-CREATION 
>   libnepomukcore/query/resultiterator.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105287/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120711/6127fc4a/attachment.html>