[Nepomuk] [Kde-pim] nepomukqueryservice crash

[Volker Krause]

On Monday 09 July 2012 16:44:43 Vishesh Handa wrote:
> On Sun, Jul 8, 2012 at 4:30 PM, Volker Krause <vkrause at kde.org> wrote:
> > On Sunday 08 July 2012 09:40:32 David Faure wrote:
> > > On Saturday 07 July 2012 11:13:08 Volker Krause wrote:
> > > > On Friday 06 July 2012 14:44:30 David Faure wrote:
> > > > > I found the reason for the kmail composer window being disabled
> > 
> > forever,
> > 
> > > > > in
> > > > > some cases.
> > > > > 
> > > > > A blocking nepomuk query from an akonadiserver thread never
> > 
> > terminates,
> > 
> > > > > because nepomukqueryservice crashes meanwhile.
> > > > > 
> > > > > This leads to two bugs:
> > > > > 
> > > > > 1) queryserviceclient should kill blocking queries when
> > > > > _k_serviceUnregistered tells us the service crashed.
> > > > > The attached patch works for me, OK if I commit it to all
> > > > > appropriate
> > > > > branches? (kdelibs 4.8, kdelibs 4.9, nepomuk-core, akonadi master --
> > > > > LOL)
> 
> Ship it!
> 
> > > > +1 as far as Akonadi is concerned. We don't have
> > 
> > _k_serviceUnregistered at
> > 
> > > > all though, so this might require backporting a few more changes of
> > > > the
> > > > queryserviceclient code.
> > > 
> > > Yep, I have these commits ready for akonadi. Just waiting for an OK from
> > 
> > the
> > 
> > > nepomuk side.
> 
> Why does Akonadi have its own copy of the QueryServiceClient? Can't you
> just use ours?

The Akonadi server is in kdesupport and does not depends on kdelibs. Therefore 
using the Nepomuk one wasn't possible so far. Now with all the framework-
ification and the existence of nepomuk-core we might be able to revisit that.

regards,
Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120709/15ff93db/attachment.sig>