[Nepomuk] Review Request: PropertyChanged Signal in the Resource Watcher
Vishesh Handa
handa.vish at gmail.com
Tue Jan 17 19:02:45 UTC 2012
> On Jan. 5, 2012, 2 p.m., Sebastian Trueg wrote:
> > nepomuk/services/storage/resourcewatcherconnection.h, line 56
> > <http://git.reviewboard.kde.org/r/103522/diff/1/?file=44667#file44667line56>
> >
> > Why not lists?
I tried a variant list, but the signal wasn't getting emitted. Eventually I got fed up and just used a variant.
It can be changed later if someone can figure out how to send a variant list.
> On Jan. 5, 2012, 2 p.m., Sebastian Trueg wrote:
> > nepomuk/interfaces/org.kde.nepomuk.ResourceWatcherConnection.xml, line 33
> > <http://git.reviewboard.kde.org/r/103522/diff/1/?file=44662#file44662line33>
> >
> > This look incorrect.
What's wrong?
According to the DBus Specification - "VARIANT has ASCII character 'v' as its type code. A marshaled value of type VARIANT will have the signature of a single complete type as part of the value. This signature will be followed by a marshaled value of that type."
http://dbus.freedesktop.org/doc/dbus-specification.html#message-protocol-signatures
- Vishesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103522/#review9570
-----------------------------------------------------------
On Dec. 23, 2011, 4:12 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103522/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2011, 4:12 p.m.)
>
>
> Review request for Nepomuk, Martin Klapetek and Sebastian Trueg.
>
>
> Description
> -------
>
> Implemented the propertyChanged signal in the Resource Watcher.
>
> DBus is retarded. It refuses to work if I sent the changed list as a variant/variant list. It works if I send it as a string list though.
>
>
> Diffs
> -----
>
> nepomuk/interfaces/org.kde.nepomuk.ResourceWatcherConnection.xml 8b175bc
> nepomuk/services/storage/datamanagementmodel.h 2660837
> nepomuk/services/storage/datamanagementmodel.cpp b4e38aa
> nepomuk/services/storage/lib/resourcewatcher.h ac4425d
> nepomuk/services/storage/lib/resourcewatcher.cpp f6fc93c
> nepomuk/services/storage/resourcewatcherconnection.h 6100fb4
> nepomuk/services/storage/resourcewatchermanager.h 707ddab
> nepomuk/services/storage/resourcewatchermanager.cpp 6276254
>
> Diff: http://git.reviewboard.kde.org/r/103522/diff/diff
>
>
> Testing
> -------
>
> Works perfectly. Tried monitoring NAO:numericRating
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120117/0eb00ee4/attachment.html>
More information about the Nepomuk
mailing list