[Nepomuk] Review Request: Create the ResourceWathcer when loading the data in Nepomuk::Resource

[Sebastian Trueg]

> On Feb. 20, 2012, 4:37 p.m., Sebastian Trueg wrote:
> > Nice catch. please port everywhere. :/
> 
> Vishesh Handa wrote:
>     Hey Sebastian.
>     
>     I just noticed that I accidentally committed this in nepomuk-core with the nepomuk:/me patch. Should I revert the nepomuk:/me patch? and commit it again?

no, I suppose that's fine.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104029/#review10766
-----------------------------------------------------------


On Feb. 20, 2012, 2:32 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104029/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2012, 2:32 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> There is no point in updating the cache, if the cache hasn't been created.
> 
> In a lot of places (eg - queryservice ) Nepomuk::Resource::uri() is used, which lands up calling determineUri and would then send a dbus call for the resource to get added to the ResourceWatcher. We don't want that additional overhead.
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/resource/resourcedata.cpp 434a6a5 
> 
> Diff: http://git.reviewboard.kde.org/r/104029/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120221/bfabc284/attachment.html>