[Nepomuk] Review Request: Update the kick off lists on creation of Nepomuk::Resource

Sebastian Trueg sebastian at trueg.de
Tue Feb 14 19:18:14 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103983/#review10635
-----------------------------------------------------------



nepomuk/core/resourcedata.cpp
<http://git.reviewboard.kde.org/r/103983/#comment8678>

    Just put it in the if() above



nepomuk/core/resourcedata.cpp
<http://git.reviewboard.kde.org/r/103983/#comment8679>

    Would it not be enough to do this in determineUri?



nepomuk/core/resourcedata.cpp
<http://git.reviewboard.kde.org/r/103983/#comment8677>

    setting prefLabel here seems a bit much.


- Sebastian Trueg


On Feb. 14, 2012, 4:16 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103983/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2012, 4:16 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> This has been done so that stuff like -
> 
> Nepomuk::Resource tag("does-not-exist");
> kDebug() << tag.genericLabel();
> 
> and Nepomuk::Resource file("file:///home/vishesh/Not-in-nepomuk-repo");
> file.property( NIE::url() );
> 
> works.
> 
> 
> Diffs
> -----
> 
>   nepomuk/core/resourcedata.cpp ae21b58 
> 
> Diff: http://git.reviewboard.kde.org/r/103983/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120214/f814d12f/attachment.html>


More information about the Nepomuk mailing list