[Nepomuk] Review Request: Fix FLAC files - remove 'db' in replaygain

[Jos van den Oever]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103977/#review10626
-----------------------------------------------------------

Ship it!


Looks good, but I'd avoid the unneeded allocations.



lib/endanalyzers/flacendanalyzer.cpp
<http://git.reviewboard.kde.org/r/103977/#comment8675>

    It makes sense to modify the incoming string in-place. This avoids a memory allocation.
    You could use two indexes and move the numbers to the front then resize afterwards.
    In that way, there is probably no reallocation at all.


- Jos van den Oever


On Feb. 14, 2012, 11:54 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103977/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2012, 11:54 a.m.)
> 
> 
> Review request for Nepomuk and Strigi.
> 
> 
> Description
> -------
> 
> FLAC files have a parameter named "replaygain" which is in the format "<num> dB", and because of that Nepomuk cannot parse it as a float.
> 
> 
> Diffs
> -----
> 
>   lib/endanalyzers/flacendanalyzer.cpp c043872 
> 
> Diff: http://git.reviewboard.kde.org/r/103977/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120214/9ba31f30/attachment.html>