[Nepomuk] Review Request: Extract tracknumber and track count from a value like "03/16"

[Jos van den Oever]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103911/#review10485
-----------------------------------------------------------

Ship it!


This patch looks good. Perhaps albumTrackCount is available from another field somehow too, but this is a good improvement already.

- Jos van den Oever


On Feb. 10, 2012, 12:34 p.m., Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103911/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2012, 12:34 p.m.)
> 
> 
> Review request for Nepomuk, Strigi and Jos van den Oever.
> 
> 
> Description
> -------
> 
> Sometimes the track number value is something like "03/16" meaning track 3 of 16 tracks in total. This value cannot be converted into an int which makes indexing fail. The solution is to properly split the value and store nmm:trackNumber on the track and nmm:albumTrackCount on the album.
> 
> 
> Diffs
> -----
> 
>   lib/endanalyzers/flacendanalyzer.cpp c043872 
>   lib/throughanalyzers/oggthroughanalyzer.cpp 26faa15 
> 
> Diff: http://git.reviewboard.kde.org/r/103911/diff/diff
> 
> 
> Testing
> -------
> 
> Tested with a flac file. Works fine.
> 
> 
> Thanks,
> 
> Sebastian Trueg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120210/c0d5d227/attachment.html>