[Nepomuk] Review Request: Plugin to index various file formats supported by Okular

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107939/#review24047
-----------------------------------------------------------



services/fileindexer/indexer/okularextractor.cpp
<http://git.reviewboard.kde.org/r/107939/#comment18333>

    But do we need Okular to monitor configuration changes for us? I'm not sure how/why this affects us.



services/fileindexer/indexer/okularextractor.cpp
<http://git.reviewboard.kde.org/r/107939/#comment18332>

    sorry. nitpick. Could you remove the space between the QScopedPointer and < ?
    



services/fileindexer/indexer/okularextractor.cpp
<http://git.reviewboard.kde.org/r/107939/#comment18334>

    Please check if this can be converted into a int and accordingly add it. 



services/fileindexer/indexer/okularextractor.cpp
<http://git.reviewboard.kde.org/r/107939/#comment18335>

    Please convert to a QDateTime



services/fileindexer/indexer/okularextractor.cpp
<http://git.reviewboard.kde.org/r/107939/#comment18336>

    Ditto


- Vishesh Handa


On Dec. 27, 2012, 1:08 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107939/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2012, 1:08 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> Use the Okular API to extract information out of files that are supported by Okular (mobi/epub/etc) with the added exception of not indexing pdf files.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6766e4b112258465aee93cd1d13cf619b1f3aa5e 
>   services/fileindexer/indexer/CMakeLists.txt f7b5d2a29dc4098cda3997f338adf45b211c4872 
>   services/fileindexer/indexer/main.cpp 4d6fcfdb1b5231bd8af1c606f4b13a0cae89639d 
>   services/fileindexer/indexer/nepomukokularextractor.desktop PRE-CREATION 
>   services/fileindexer/indexer/okularextractor.h PRE-CREATION 
>   services/fileindexer/indexer/okularextractor.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107939/diff/
> 
> 
> Testing
> -------
> 
> Indexed an epub file using : nepomukindexer --data file.epub, could see all the data that was indexed on the terminal
> 
> Sample epub : https://epub-samples.googlecode.com/files/epub30-spec-20121128.epub
> 
> NOTE: Install kdegraphics-mobi to get mobi support.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121227/7f41a35c/attachment-0001.html>