[Nepomuk] Review Request: Plugin to index various file formats supported by Okular

[Rohan Garg]

> On Dec. 27, 2012, 11:19 a.m., Vishesh Handa wrote:
> > services/fileindexer/indexer/okularextractor.cpp, line 45
> > <http://git.reviewboard.kde.org/r/107939/diff/1/?file=101710#file101710line45>
> >
> >     If it's not too much trouble, could you please add a comment over here indicating all the mimetypes it handles. Approximately.

Done


> On Dec. 27, 2012, 11:19 a.m., Vishesh Handa wrote:
> > services/fileindexer/indexer/okularextractor.cpp, line 70
> > <http://git.reviewboard.kde.org/r/107939/diff/1/?file=101710#file101710line70>
> >
> >     This page - http://api.kde.org/4.x-api/kdegraphics-apidocs/okular/html/classOkular_1_1DocumentInfo.html seems to indicate a lot more information that you can fetch. Could you please also add that?
> >     
> >     Specifically - 
> >     
> >     Producer -> nie:generator
> >     Copyright -> nie:copyright
> >     CreationDate -> nie:contentCreated
> >     ModificationDate -> nie:content
> >     Description -> nie:description? I'm not sure about this cause the nie:discription is also used in the comment widget in Dolphin.
> >     
> >     Title -> nie:title

I haven't added Description, maybe we should discuss this somewhere?


- Rohan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107939/#review24033
-----------------------------------------------------------


On Dec. 27, 2012, 1:08 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107939/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2012, 1:08 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> Use the Okular API to extract information out of files that are supported by Okular (mobi/epub/etc) with the added exception of not indexing pdf files.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6766e4b112258465aee93cd1d13cf619b1f3aa5e 
>   services/fileindexer/indexer/CMakeLists.txt f7b5d2a29dc4098cda3997f338adf45b211c4872 
>   services/fileindexer/indexer/main.cpp 4d6fcfdb1b5231bd8af1c606f4b13a0cae89639d 
>   services/fileindexer/indexer/nepomukokularextractor.desktop PRE-CREATION 
>   services/fileindexer/indexer/okularextractor.h PRE-CREATION 
>   services/fileindexer/indexer/okularextractor.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107939/diff/
> 
> 
> Testing
> -------
> 
> Indexed an epub file using : nepomukindexer --data file.epub, could see all the data that was indexed on the terminal
> 
> Sample epub : https://epub-samples.googlecode.com/files/epub30-spec-20121128.epub
> 
> NOTE: Install kdegraphics-mobi to get mobi support.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121227/4ebdf8c2/attachment.html>