[Nepomuk] Review Request: handle exiv2 exception gracefully in nepomukindexer

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107898/#review23946
-----------------------------------------------------------

Ship it!


Thanks. I think we should improve the mimetype detection so that it works on more than just the filename.

- Vishesh Handa


On Dec. 24, 2012, 10:52 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107898/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2012, 10:52 a.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> touch 1.png; nepomukindexer 1.png
> will reproduce this problem, exception from exiv2 need to be caught.
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/indexer/CMakeLists.txt ff3c25c 
>   services/fileindexer/indexer/exiv2extractor.cpp 81e9db0 
> 
> Diff: http://git.reviewboard.kde.org/r/107898/diff/
> 
> 
> Testing
> -------
> 
> invalid image can pass.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121224/e2e1faeb/attachment.html>