[Nepomuk] Review Request: Create a kcm group for the nepomuk desktop search

[Jörg Ehrichs]

> On Dec. 23, 2012, 5:14 p.m., Vishesh Handa wrote:
> > nepomuk/kcm/kcm_nepomuk.desktop, line 15
> > <http://git.reviewboard.kde.org/r/107884/diff/1/?file=100861#file100861line15>
> >
> >     Does this mean that the user will be now see "Nepomuk Server" written on the side?
> 
> Jörg Ehrichs wrote:
>     In the kcm it stays as "Desktop Seach" if you open this category and no other program is added there (namely my webminer) it looks the same as before.
>     If something is added then yes. the current configuration is named "Nepomuk Server" on the left side.
>     
>     I'm open to anything that might fit any better.
> 
> Vishesh Handa wrote:
>     Could it be called "Desktop Search" even on the side? Or would that result in a name clash?

Yes that is possible.
But to be honest i don't like this. Mostly because non of the settings in there have anything to do with searching.
Also it looks "wrong" to have Desktop Search->Desktop Search.

But its your call.


- Jörg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107884/#review23912
-----------------------------------------------------------


On Dec. 23, 2012, 5:10 p.m., Jörg Ehrichs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107884/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2012, 5:10 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> In order to be able to add the nepomuk webminer configuration to the nepomuk 'Desktop Search' category in the kcm.
> This category must be created first.
>     
> This patch adds a new systemsettings category with the name'Desktop Search' and adds the Nepomuk configuration with the name 'Nepomuk Server'.
> 
> 
> Diffs
> -----
> 
>   nepomuk/kcm/desktop-search.desktop PRE-CREATION 
>   nepomuk/kcm/kcm_nepomuk.desktop caff3c3 
> 
> Diff: http://git.reviewboard.kde.org/r/107884/diff/
> 
> 
> Testing
> -------
> 
> Tested and now the Nepomuk-Webminer can be added to the Desktop Search category.
> Without the Webminer the lookand feel of the kcm stays exactly the same.
> 
> 
> Thanks,
> 
> Jörg Ehrichs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121223/49c03723/attachment.html>