[Nepomuk] Review Request: Fix crash when using nepomukcleaner with nepomuk disabled.

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107793/#review23648
-----------------------------------------------------------

Ship it!


Please commit to KDE/4.10

About that other commit, feel free to merge 'master' into KDE/4.10. AFAIK, it shouldn't break anything. If that doesn't work, then you can cherry-pick.


cleaner/mainwindow.cpp
<http://git.reviewboard.kde.org/r/107793/#comment18107>

    ?


- Vishesh Handa


On Dec. 18, 2012, 1:54 a.m., Simeon Bird wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107793/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2012, 1:54 a.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> Fix crash when using nepomukcleaner with nepomuk disabled. When nepomuk is disabled, now just exits.
> 
> Needs the related soprano review to actually work
> 
> ==Unrelated==
> Could I also backport 56e476cd9b995143b4ca9a67257dc7642c879841 to KDE/4.10? 
> 
> It fixes a crash, of the sort that we would probably get hundreds of bug reports about if it were released, in a pretty uncontroversial manner, 
> so I committed it to master before noticing the release freeze had already started. 
> 
> 
> This addresses bug 311753.
>     http://bugs.kde.org/show_bug.cgi?id=311753
> 
> 
> Diffs
> -----
> 
>   cleaner/jobmodel.cpp e8e9acf 
>   cleaner/mainwindow.cpp 9b7f0c7 
> 
> Diff: http://git.reviewboard.kde.org/r/107793/diff/
> 
> 
> Testing
> -------
> 
> Yup, no crash! 
> 
> 
> Thanks,
> 
> Simeon Bird
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121218/5606cfb2/attachment-0001.html>