[Nepomuk] Review Request: Make ${NEPOMUK_CORE_DBUS_INTERFACES_DIR} an absolute path; fixes problem building kde-runtime on WinXP

Thomas Friedrichsmeier thomas.friedrichsmeier at ruhr-uni-bochum.de
Tue Dec 11 12:39:44 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107665/
-----------------------------------------------------------

Review request for kdewin and Nepomuk.


Description
-------

Frankly, I am not sure at all, whether this is the correct place to fix the issue.
Either way, without this, building of kde-runtime on WinXP fails, because calls like the following (in kde-runtime/nepomuk/kcm/CMakeLists.txt):
  qt4_add_dbus_interface(kcmnepomuk_SRCS ${NEPOMUK_CORE_DBUS_INTERFACES_DIR}/org.kde.NepomukServer.xml nepomukserverinterface)
will look for the interface in a location _relative_ to the current sources. Sorry, I forgot to make a copy of the exact error message.

Making ${NEPOMUK_CORE_DBUS_INTERFACES_DIR} an absolute path works around this, successfully, but again, I'm not sure, whether that is the correct fix.


Diffs
-----

  NepomukCoreConfig.cmake.in 81c084b50ea065d98798bf86e698dfdf1c8284d7 

Diff: http://git.reviewboard.kde.org/r/107665/diff/


Testing
-------

With the patch to nepomuk-core, kde-runtime compiles with MinGW4 on WinXP. Previously it did not.


Thanks,

Thomas Friedrichsmeier

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121211/99fb360a/attachment.html>


More information about the Nepomuk mailing list