[Nepomuk] Review Request: NepomukMainModel: Never reset the localSocketModel

[Simeon Bird]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107533/#review23217
-----------------------------------------------------------

Ship it!


Ship It!

- Simeon Bird


On Nov. 30, 2012, 1:54 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107533/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2012, 1:54 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     NepomukMainModel: Never reset the localSocketModel
>     
>     We now never create a new LocalSocketModel on reconnecting. Instead we
>     continue using the old one. This way we do not leak memory, as we could
>     not delete the old model (open iterators).
>     
>     This is only possibly cause of the recent changes in Soprano which never
>     delete the inner ClientConnection which is shared between the model and
>     the LocalSocketClient. Before that commit the ClientConnection was
>     deleted which would result in the old model becoming invalid.
> 
> This depends on https://git.reviewboard.kde.org/r/107531/
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/resource/nepomukmainmodel.cpp 76bd6a3 
> 
> Diff: http://git.reviewboard.kde.org/r/107533/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121209/cc295018/attachment.html>