[Nepomuk] Review Request: Make ResourceManager::generateUniqueUri not use SPARQL unions

Gabriel Poesia gabriel.poesia at gmail.com
Sat Dec 8 20:11:01 UTC 2012



> On Dec. 8, 2012, 7:23 p.m., Vishesh Handa wrote:
> > Perfect.
> > 
> > Do you want to commit this yourself?
> 
> Gabriel Poesia wrote:
>     Yes, I do :)
>     I'll ask for a developer account, then. May I name you as the supporter?
> 
> Vishesh Handa wrote:
>     Of course.

Thanks :)
I just submitted the developer account application.


- Gabriel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107637/#review23161
-----------------------------------------------------------


On Dec. 8, 2012, 7:18 p.m., Gabriel Poesia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107637/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2012, 7:18 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> The change is exactly what's suggested in the bug's description. 
> Instead of running a SPARQL query using unions to check if a given URI already exists, use the "iri_to_id" command.
> 
> 
> This addresses bug 311061.
>     http://bugs.kde.org/show_bug.cgi?id=311061
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/resource/resourcemanager.cpp 457c042 
> 
> Diff: http://git.reviewboard.kde.org/r/107637/diff/
> 
> 
> Testing
> -------
> 
> Wrote a simple program to call the function and display the results. The output seems fine.
> 
> 
> Thanks,
> 
> Gabriel Poesia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121208/64d255e3/attachment-0001.html>


More information about the Nepomuk mailing list