[Nepomuk] Review Request: Make ResourceManager::generateUniqueUri not use SPARQL unions
Vishesh Handa
me at vhanda.in
Sat Dec 8 19:23:57 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107637/#review23161
-----------------------------------------------------------
Ship it!
Perfect.
Do you want to commit this yourself?
- Vishesh Handa
On Dec. 8, 2012, 7:18 p.m., Gabriel Poesia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107637/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2012, 7:18 p.m.)
>
>
> Review request for Nepomuk and Vishesh Handa.
>
>
> Description
> -------
>
> The change is exactly what's suggested in the bug's description.
> Instead of running a SPARQL query using unions to check if a given URI already exists, use the "iri_to_id" command.
>
>
> This addresses bug 311061.
> http://bugs.kde.org/show_bug.cgi?id=311061
>
>
> Diffs
> -----
>
> libnepomukcore/resource/resourcemanager.cpp 457c042
>
> Diff: http://git.reviewboard.kde.org/r/107637/diff/
>
>
> Testing
> -------
>
> Wrote a simple program to call the function and display the results. The output seems fine.
>
>
> Thanks,
>
> Gabriel Poesia
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121208/eeab6ce6/attachment.html>
More information about the Nepomuk
mailing list