[Nepomuk] Review Request: Client Local Socket: Check for EINTR error in socket calls
Vishesh Handa
me at vhanda.in
Thu Dec 6 09:36:04 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107607/
-----------------------------------------------------------
Review request for Nepomuk, Soprano, Sebastian Trueg, and Simeon Bird.
Description
-------
Client Local Socket: Check for EINTR error in socket calls
Sometimes the calls to select, read, and write return with an EINTR
(Interrupted System call) error. The documentation says that in that
case, one should just try again.
This solves some of the mysterious bugs of the socket timing out, and
then returning errors. I could reproduce this issue by running a large
number of queries in parallel by the nepomuk file indexer.
Also, cleaned up the SocketStream code a little bit. It no longer needs
those extra checks in its read and write functions.
Diffs
-----
client/socket.cpp 28ac163
client/socketstream.cpp 4db8be3
Diff: http://git.reviewboard.kde.org/r/107607/diff/
Testing
-------
No more "Socket timed out error", and other problems. The errors were completely reproducible.
Thanks,
Vishesh Handa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121206/5beb2b64/attachment-0001.html>
More information about the Nepomuk
mailing list