[Nepomuk] Review Request: LocalSocketClient: Never delete the ClientConnection

[Simeon Bird]

> On Dec. 3, 2012, 4:36 a.m., Simeon Bird wrote:
> > This is an amazingly good idea. 
> > The simpler this bit of code is, the more chance we have to debug some of the crazy crashes we're getting!
> 
> Simeon Bird wrote:
>     This should fix 305312 as well, right?
> 
> Vishesh Handa wrote:
>     I'm not sure. 
>     
>     The LocalSocketClient is still getting deleted when the MainModel is deleted, which is what seems to be crashing in this bug report.

hmm, it's a question. If the problem is that the LocalSocketClient is being deleted before the MainModel, and then deleted again, then this would fix it. 

On the other hand, if LocalSocketClient is still being used somehow after deletion by another thread, I guess it would not. 
I'll take a look at some point...


- Simeon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107531/#review22926
-----------------------------------------------------------


On Nov. 30, 2012, 1:23 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107531/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2012, 1:23 p.m.)
> 
> 
> Review request for Nepomuk, Soprano and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     LocalSocketClient: Never delete the ClientConnection
>     
>     The ClientConnection is not reference counted, and is passed to the the
>     model and open iterators. Deleting it when has open iterators therefore
>     leads to crashes.
>     
>     Instead, the ClientConnection is always persistent. Intead we provide
>     functions to allow users of the ClientConnection to connect and
>     disconnect.
>     
>     Also removed the concept of newConnection() from the ClientConnection.
>     It no longer spawns a new socket for each thread, so there is no point
>     of it existing. This new design is a lot simpler.
> 
> 
> Diffs
> -----
> 
>   client/clientconnection.h bfb3d4d 
>   client/clientconnection.cpp febd008 
>   client/localsocketclient.cpp f3579ff 
> 
> Diff: http://git.reviewboard.kde.org/r/107531/diff/
> 
> 
> Testing
> -------
> 
> Yup. Everything works fine.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121205/12da9f00/attachment.html>