[Nepomuk] Review Request: Add button to force the file indexer update all folders

Vishesh Handa me at vhanda.in
Tue Dec 4 19:01:13 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107553/#review22987
-----------------------------------------------------------

Ship it!


Seems good enough to me. We will eventually figure out more stuff to add.

Now the main problem is that we will have to wait for about a month to commit this in master (String freeze)

- Vishesh Handa


On Dec. 4, 2012, 6:54 p.m., Gabriel Poesia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107553/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2012, 6:54 p.m.)
> 
> 
> Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> Add a button to the KCM Nepomuk as suggested in bug #303658. When clicked, the indexer executes the updateAllFolders() method.
> The widget was placed in the Nepomuk Repository Details dialog, along with the "Suspend/Resume File Indexing". I'm not sure if it violates
> any design principles behind KDE, KCM or Nepomuk (if it should have an icon, for example, like the two other buttons in the dialog).
> 
> 
> This addresses bug 303658.
>     http://bugs.kde.org/show_bug.cgi?id=303658
> 
> 
> Diffs
> -----
> 
>   nepomuk/kcm/nepomukconfigwidget.ui 3534213 
>   nepomuk/kcm/nepomukserverkcm.h c8f9a6b 
>   nepomuk/kcm/nepomukserverkcm.cpp e27a6a2 
> 
> Diff: http://git.reviewboard.kde.org/r/107553/diff/
> 
> 
> Testing
> -------
> 
> Compiled, installed, ran kcmshell4 nepomuk. The file indexer was idle. 
> Clicking the button changed the status message to "Scanning for recent changes in [...]".
> 
> 
> Screenshots
> -----------
> 
> New look of the button
>   http://git.reviewboard.kde.org/r/107553/s/870/
> 
> 
> Thanks,
> 
> Gabriel Poesia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121204/2f055326/attachment.html>


More information about the Nepomuk mailing list