[Nepomuk] Review Request: Watch fixes for symlinks and fiters

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107080/#review22940
-----------------------------------------------------------



services/fileindexer/fileindexerconfig.cpp
<http://git.reviewboard.kde.org/r/107080/#comment17530>

    I'm not sure about this. Suppose a user has set "DirA" to be indexed. And that contains a system link to "B".
    
    
    A
    A/DirA
    A/DirA/linkToB
    A/DirB
    B/
    
    Then shouldn't all the files and folders in B get indexed as well?
    
    I'm not sure how we would handle that in the IndexCleaner.



services/filewatch/nepomukfilewatch.cpp
<http://git.reviewboard.kde.org/r/107080/#comment17528>

    How come this doesn't work?



services/filewatch/nepomukfilewatch.cpp
<http://git.reviewboard.kde.org/r/107080/#comment17529>

    What cases does this cover?


- Vishesh Handa


On Nov. 10, 2012, 12:30 a.m., Simeon Bird wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107080/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 12:30 a.m.)
> 
> 
> Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> Some fixes for filtering, and some symlink handling (this is patch 2).
> 
> 1. Do not watch symlinks when their target is already watched (by being in the hash of watched paths).
> 
> This does not stop all double-watching of symlinks,
> because the watch on the symlink may be installed before
> the watch on the target.
> 
> However, it prevents infinite recursion if someone has done this:
> 
> mkdir ~/test
> cd test
> ln -s ../ test
> 
> which is nice. 
> 
> 2. Do not re-index symlinks to folders that are already indexed under
> another name. This just saves some CPU cycles and double-counting of results in dolphin search.
> 
> 3. Do not watch folders in the filter exclude list. By
>  default this affects only CMakeFiles and auto4mte (as agreed with Vishesh earlier)
> 
> 4. Do not override addWatch in IgnoringKInotify. This was intended to avoid watching folders on
> the exclude list, but did not really work, and is implemented better by 3. 
> 
> 
> This addresses bugs 208602 and 306342.
>     http://bugs.kde.org/show_bug.cgi?id=208602
>     http://bugs.kde.org/show_bug.cgi?id=306342
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/fileindexerconfig.cpp 5226a79 
>   services/filewatch/nepomukfilewatch.cpp dbe2f82 
> 
> Diff: http://git.reviewboard.kde.org/r/107080/diff/
> 
> 
> Testing
> -------
> 
> Compiled, checked that the cases listed are watched or not watched correctly. 
> 
> 
> Thanks,
> 
> Simeon Bird
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121203/768f109e/attachment.html>