[Nepomuk] Review Request: QueryLibrary: Do not use nao:userVisible for filtering

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106282/#review18317
-----------------------------------------------------------



libnepomukcore/query/query.cpp
<http://git.reviewboard.kde.org/r/106282/#comment14486>

    This implies that all the information you query is in the same graph. That is not always the case. Actually, it is less likely the more information you have in Nepomuk.


- Sebastian Trueg


On Aug. 30, 2012, 9:50 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106282/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2012, 9:50 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> The additional "?r a [ nao:userVisible "true"^^xsd:boolean ] ." slows down the query a lot because of the massive joins in the generated SQL. It seems better to use graph ?g { .. } ?g a nrl:InstanceBase, which would also filter out the results.
> 
> Additionally, the nao:userVisible trick does not work for negation terms and lists out the classes.
> 
> I'd like to get this into 4.9.1 if possible. Please review fast.
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/query/query.cpp 21b9aa3 
> 
> Diff: http://git.reviewboard.kde.org/r/106282/diff/
> 
> 
> Testing
> -------
> 
> Yup. Manually tested, and it fixes some of my the tests in my query tests (still not pushed, but I can push if anyone is interested) 
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120831/688ddc7d/attachment.html>