[Nepomuk] Review Request: QueryLibrary: Do not use nao:userVisible for filtering

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106282/
-----------------------------------------------------------

Review request for Nepomuk and Sebastian Trueg.


Description
-------

The additional "?r a [ nao:userVisible "true"^^xsd:boolean ] ." slows down the query a lot because of the massive joins in the generated SQL. It seems better to use graph ?g { .. } ?g a nrl:InstanceBase, which would also filter out the results.

Additionally, the nao:userVisible trick does not work for negation terms and lists out the classes.

I'd like to get this into 4.9.1 if possible. Please review fast.


Diffs
-----

  libnepomukcore/query/query.cpp 21b9aa3 

Diff: http://git.reviewboard.kde.org/r/106282/diff/


Testing
-------

Yup. Manually tested, and it fixes some of my the tests in my query tests (still not pushed, but I can push if anyone is interested) 


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120830/c9ec9430/attachment.html>