[Nepomuk] Review Request: Dolphin Places: Only show file results in Nepomuk Queries

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106274/
-----------------------------------------------------------

(Updated Aug. 30, 2012, 11:08 a.m.)


Review request for Dolphin and Nepomuk.


Changes
-------

Typo


Summary (updated)
-----------------

Dolphin Places: Only show file results in Nepomuk Queries


Description
-------

    Dolphin is a file manager, and shouldn't be concerned with non-file
    resources like notes, contacts and other stuff.
    
    Use FileQuery instead of Query.
    
    This also results in a faster queries. With File Queries Nepomuk can
    perform some internal optimizations.

PS: I'd like to get this into 4.9.1, so a fast review would be nice. Also, do we cherry pick or merge KDE/4.9 into master?


Diffs
-----

  dolphin/src/panels/places/placesitemmodel.cpp 4979013 

Diff: http://git.reviewboard.kde.org/r/106274/diff/


Testing
-------


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120830/dc671bf1/attachment.html>