[Nepomuk] Review Request: NepomukSearch: Fetch the mimetype from the database
Sebastian Trueg
sebastian at trueg.de
Wed Aug 29 15:36:17 UTC 2012
> On Aug. 29, 2012, 2:01 p.m., Sebastian Trueg wrote:
> > nepomuk/kioslaves/search/searchfolder.cpp, line 225
> > <http://git.reviewboard.kde.org/r/106264/diff/2/?file=82222#file82222line225>
> >
> > there is no need for this query. Just always request the mimetype in queryutils.cpp.
>
> Vishesh Handa wrote:
> Okay we have a slight problem - Not all queries which query files are file queries, and thus they do not get those extra requested properties. So, maybe we could do a combination of my previous patch along with extra request properties for when they are file queries?
>
> Sebastian Trueg wrote:
> Well, I suppose you can always add the mimetype as an optional one. What's the harm? Aren't most queries actually file queries if not of type FileQuery?
>
> Vishesh Handa wrote:
> Nope. Dolphin seems to be making a lot of queries without marking them as FileQueries. Anyway, I have a patch to fix that in Dolphin.
I meant queries that should return files which are not FileQuerys.
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106264/#review18245
-----------------------------------------------------------
On Aug. 29, 2012, 1:55 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106264/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2012, 1:55 p.m.)
>
>
> Review request for Nepomuk and Sebastian Trueg.
>
>
> Description
> -------
>
> Instead of determining it based on the file url. We already know the
> mimetype after we index the file.
>
>
> Diffs
> -----
>
> nepomuk/kioslaves/search/searchfolder.cpp 96d1899
>
> Diff: http://git.reviewboard.kde.org/r/106264/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120829/20e2a5e0/attachment-0001.html>
More information about the Nepomuk
mailing list