[Nepomuk] Review Request: Optimize sending of LiteralValue over the socket

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106233/#review18248
-----------------------------------------------------------


What code duplication do you mean?
This looks fine. I suppose it means another speed up?

- Sebastian Trueg


On Aug. 27, 2012, 10:30 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106233/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2012, 10:30 a.m.)
> 
> 
> Review request for Nepomuk, Soprano, Aleix Pol Gonzalez, and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     Optimize sending of LiteralValue over the socket
>     
>     Instead of sending it as <literal-value-string><literal-value-type>.
>     Send it as a string/int/bool/whatever when possible, and only send it
>     with the full type as a last resort.
>     
>     This results in code duplication, but that should be fixed by deriving
>     both the classes from a common class.
> 
> 
> Diffs
> -----
> 
>   client/socketstream.cpp 7178580 
>   server/datastream.cpp 17c0c41 
> 
> Diff: http://git.reviewboard.kde.org/r/106233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120829/719ee18b/attachment.html>