[Nepomuk] Review Request: Client: Cache the current bindings

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106231/#review18247
-----------------------------------------------------------

Ship it!


Brilliant.

- Sebastian Trueg


On Aug. 27, 2012, 10:22 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106231/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2012, 10:22 a.m.)
> 
> 
> Review request for Nepomuk, Soprano, Aleix Pol Gonzalez, and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     Client: Cache the current bindings
>     
>     Cache the current bindings when running the next() in a local variable.
>     This way we avoid asking for it during each operator[] and current.
>     
>     Results in a MASSIVE performance boost - 6 secs vs 1 sec on a large
>     query which had a lot of bindings.
> 
> 
> Diffs
> -----
> 
>   client/clientqueryresultiteratorbackend.h 2d10756 
>   client/clientqueryresultiteratorbackend.cpp babbdcc 
> 
> Diff: http://git.reviewboard.kde.org/r/106231/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120829/4e61ba76/attachment.html>