[Nepomuk] Review Request: QueryService: Use heuristics to determine when to re-run the query

Sebastian Trueg sebastian at trueg.de
Wed Aug 29 11:46:59 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106238/#review18232
-----------------------------------------------------------

Ship it!


Apart from missing comments I think this is a good optimization.


services/queryservice/folder.cpp
<http://git.reviewboard.kde.org/r/106238/#comment14432>

    How about explaining this a bit in a comment?



services/queryservice/folder.cpp
<http://git.reviewboard.kde.org/r/106238/#comment14431>

    How about explaining this a bit in a comment?


- Sebastian Trueg


On Aug. 29, 2012, 10:09 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106238/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2012, 10:09 a.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     Instead of running all the queries any time ANY data in the database
>     changes.
> 
> 
> Diffs
> -----
> 
>   services/queryservice/folder.cpp e95be8d 
> 
> Diff: http://git.reviewboard.kde.org/r/106238/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120829/ef97310c/attachment-0001.html>


More information about the Nepomuk mailing list