[Nepomuk] Review Request: DMS CreateResource: Simplify the types given in createResource
Sebastian Trueg
sebastian at trueg.de
Wed Aug 29 11:44:03 UTC 2012
> On Aug. 29, 2012, 10:07 a.m., Vishesh Handa wrote:
> > services/storage/datamanagementmodel.cpp, line 863
> > <http://git.reviewboard.kde.org/r/106246/diff/1/?file=81963#file81963line863>
> >
> > Cause with find I can use the iterator for removing.
Doh
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106246/#review18217
-----------------------------------------------------------
On Aug. 28, 2012, 6:48 a.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106246/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2012, 6:48 a.m.)
>
>
> Review request for Nepomuk and Sebastian Trueg.
>
>
> Description
> -------
>
> DMS CreateResource: Simplify the types given in createResource
>
> This way we avoid unnecessary extra statements, and have the minimum
> number of types in the database. Inferencing takes care of the rest.
>
>
> Diffs
> -----
>
> services/storage/datamanagementmodel.cpp bfadda5
> services/storage/test/datamanagementmodeltest.h ffe7e79
> services/storage/test/datamanagementmodeltest.cpp 8ff7777
> services/storage/test/qtest_dms.cpp a3308a1
>
> Diff: http://git.reviewboard.kde.org/r/106246/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120829/546bf83d/attachment-0001.html>
More information about the Nepomuk
mailing list