[Nepomuk] Review Request: QueryService: Use heuristics to determine when to re-run the query

[Sebastian Trueg]

> On Aug. 29, 2012, 8:18 a.m., Sebastian Trueg wrote:
> > services/queryservice/folder.cpp, line 82
> > <http://git.reviewboard.kde.org/r/106238/diff/1/?file=81846#file81846line82>
> >
> >     What if the property is empty?
> 
> Vishesh Handa wrote:
>     I guess in that case one should monitor for all properties? So, I can just not monitor any properties.

In other words: remove all properties from the watcher and remember that you did that. Otherwise another Comparisonterm could add another property afterwards.


> On Aug. 29, 2012, 8:18 a.m., Sebastian Trueg wrote:
> > services/queryservice/folder.cpp, line 85
> > <http://git.reviewboard.kde.org/r/106238/diff/1/?file=81846#file81846line85>
> >
> >     Don't you need to check NegationTerms, also?
> 
> Vishesh Handa wrote:
>     How would I handle negation terms?

Well, out of the top of my head I would think the same way as optional ones: just handle the sub-term. Imagine this example:

query: something + NOT ( hasTag: X )

now you add tag X to a resource from the result set.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106238/#review18209
-----------------------------------------------------------


On Aug. 27, 2012, 7:51 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106238/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2012, 7:51 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     Instead of running all the queries any time ANY data in the database
>     changes.
> 
> 
> Diffs
> -----
> 
>   services/queryservice/folder.cpp e95be8d 
> 
> Diff: http://git.reviewboard.kde.org/r/106238/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120829/00b9c143/attachment-0001.html>