[Nepomuk] Review Request: DMS CreateResource: Simplify the types given in createResource

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106246/#review18212
-----------------------------------------------------------



services/storage/datamanagementmodel.cpp
<http://git.reviewboard.kde.org/r/106246/#comment14417>

    In terms of safety no. But in terms of a slight extra work, yes.
    
    The docs say "If the set is modified while a QSetIterator is active, the QSetIterator will continue iterating over the original set, ignoring the modified copy."
    
    so technically, it should be fine.


- Vishesh Handa


On Aug. 28, 2012, 6:48 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106246/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2012, 6:48 a.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     DMS CreateResource: Simplify the types given in createResource
>     
>     This way we avoid unnecessary extra statements, and have the minimum
>     number of types in the database. Inferencing takes care of the rest.
> 
> 
> Diffs
> -----
> 
>   services/storage/datamanagementmodel.cpp bfadda5 
>   services/storage/test/datamanagementmodeltest.h ffe7e79 
>   services/storage/test/datamanagementmodeltest.cpp 8ff7777 
>   services/storage/test/qtest_dms.cpp a3308a1 
> 
> Diff: http://git.reviewboard.kde.org/r/106246/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120829/0c4f11b3/attachment.html>