[Nepomuk] Review Request: FileIndexer: Fix a deadlock by making the mutex recursive

Vishesh Handa me at vhanda.in
Mon Aug 27 10:09:53 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106230/
-----------------------------------------------------------

Review request for Nepomuk and Sebastian Trueg.


Description
-------

    FileIndexer: Fix a deadlock by making the mutex recursive
    
    The following deadlock occurs during the first run of the
    nepomuk-fileindexer, if you're on batery
    
    QMutex::lockInternal()
    QMutexLocker::QMutexLocker
    Nepomuk2::IndexScheduler::suspend
    Nepomuk2::EventMonitor::pauseIndexing
    QMetaObject::activate(QObject*, QMetaObject
    Nepomuk2::IndexScheduler::indexingSuspended
    Nepomuk2::IndexScheduler::suspend
    Nepomuk2::EventMonitor::pauseIndexing
    Nepomuk2::EventMonitor::slotPowerManagementStatusChanged
    Nepomuk2::EventMonitor::EventMonitor
    Nepomuk2::FileIndexer::FileIndexer
    
    This only happens during first run cause that is when the EventMonitor
    is connected to the IndexScheduler
    
    BUG: 304982


This addresses bug 304982.
    http://bugs.kde.org/show_bug.cgi?id=304982


Diffs
-----

  services/fileindexer/indexscheduler.cpp 6fe6d49 

Diff: http://git.reviewboard.kde.org/r/106230/diff/


Testing
-------

Yup. It has been fixed.


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120827/714d3989/attachment.html>


More information about the Nepomuk mailing list