[Nepomuk] Review Request: Disable SHA1 Strigi analyzer

[Simeon Bird]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105986/
-----------------------------------------------------------

(Updated Aug. 13, 2012, 11:36 p.m.)


Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.


Changes
-------

Or rather, I meant this. 

(Pass nepomukindexer the option list, not the comma-separated one)


Description
-------

This fixes https://bugs.kde.org/show_bug.cgi?id=303670 by disabling the SHA1 analyzer in strigi. 
I added an extra argument to nepomukindexer, --skip, which takes a comma-separated list of analyzers to not call. 
Then I change the invocation of nepomukindexer from the FileIndexer class so that it gets this list from a hidden option (exclude plugins) in the nepomuk config, which defaults to the SHA1 indexer.

I didn't add a KCM option because a) I don't know how to do that (this is the real reason :) ), and b) I'm not sure whether it should be a "disable SHA1" checkbox, a list, or whether we need it at all.


This addresses bug 303670.
    http://bugs.kde.org/show_bug.cgi?id=303670


Diffs (updated)
-----

  services/fileindexer/fileindexerconfig.h cc00922 
  services/fileindexer/fileindexerconfig.cpp e2265fc 
  services/fileindexer/indexer/indexer.h dc0e98a 
  services/fileindexer/indexer/indexer.cpp e4f1462 
  services/fileindexer/indexer/main.cpp a46a651 
  services/fileindexer/nepomukindexer.cpp 70abee0 

Diff: http://git.reviewboard.kde.org/r/105986/diff/


Testing
-------

Compiled, tested that nepomukindexer indeed does not call DigestEventAnalyzer with some printing. 


Thanks,

Simeon Bird

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120813/78534503/attachment-0001.html>