[Nepomuk] Review Request: FileWatch: Remove watches for removeable media before unmounting

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106002/#review17316
-----------------------------------------------------------

Ship it!


Looks very clean. Nice work as always.

- Sebastian Trueg


On Aug. 13, 2012, 1:38 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106002/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2012, 1:38 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     Added 2 signals in RemovableMediaCache
>     * deviceRemoved
>     * deviceTeardownRequested
>     
>     When the device is about to be unmounted all the watches are removed so
>     that it can be unmounted sucessfully.
>     
>     BUG: 304943
>     FIXED-IN: 4.9.1
> 
> 
> This addresses bug 304943.
>     http://bugs.kde.org/show_bug.cgi?id=304943
> 
> 
> Diffs
> -----
> 
>   common/removablemediacache.h d11a38c 
>   common/removablemediacache.cpp 8bde86e 
>   services/filewatch/nepomukfilewatch.h 92daa5f 
>   services/filewatch/nepomukfilewatch.cpp f5c51c4 
> 
> Diff: http://git.reviewboard.kde.org/r/106002/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120813/79b79759/attachment.html>