[Nepomuk] Review Request: ResourceWatcher: add *count() methods for resources, properties and types

Vishesh Handa me at vhanda.in
Wed Aug 8 14:15:43 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105927/
-----------------------------------------------------------

Review request for Nepomuk and Sebastian Trueg.


Description
-------

    ResourceWatcher: add *count() methods for resources, properties and types
    
    These count methods are faster than returning the full list and then
    counting the number of items in the list.
    
    This also fixes an infinite loop where a temporary Resource is created
    when querying for the number of resources being watched. The temporary
    Resource is deleted, which results in ResourceData::resetAll being
    callled which again called ResourceWatcher::resources(), and the cycle
    countinues.


This addresses bug 304796.
    http://bugs.kde.org/show_bug.cgi?id=304796


Diffs
-----

  libnepomukcore/datamanagement/resourcewatcher.h af20945 
  libnepomukcore/datamanagement/resourcewatcher.cpp c7fc425 
  libnepomukcore/resource/resourcedata.cpp f3590f3 

Diff: http://git.reviewboard.kde.org/r/105927/diff/


Testing
-------


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120808/03124dcd/attachment.html>


More information about the Nepomuk mailing list