[Nepomuk] Review Request: Port the QueryService to the Query::ResultIterator
Simeon Bird
bladud at gmail.com
Sun Aug 5 19:19:33 UTC 2012
> On Aug. 5, 2012, 5:54 p.m., Vishesh Handa wrote:
> > Why don't you get a developer account and commit it yourself?
Will do!
- Simeon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105872/#review16912
-----------------------------------------------------------
On Aug. 5, 2012, 5:34 p.m., Simeon Bird wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105872/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2012, 5:34 p.m.)
>
>
> Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.
>
>
> Description
> -------
>
> This is a fairly trivial patch to port the QueryService to the Query::ResultIterator; just doing something quick to get my hand in.
>
> - Changes ResourceManager::mainModel() use in QueryService to ResourceIterator
> - Removes now unneeded includes, functions, etc
> - Speed up searchRunnable.run() by storing up to 10 results in the result list before sending them to folder.addResults(). This should be faster by needing less locking overhead. I haven't actually timed it, so it may be marginal.
>
>
> This addresses bug 303383.
> http://bugs.kde.org/show_bug.cgi?id=303383
>
>
> Diffs
> -----
>
> services/queryservice/searchrunnable.h 1c12a9b
> services/queryservice/searchrunnable.cpp 451db46
>
> Diff: http://git.reviewboard.kde.org/r/105872/diff/
>
>
> Testing
> -------
>
> Compiles, dolphin search still works.
>
>
> Thanks,
>
> Simeon Bird
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120805/a253545b/attachment.html>
More information about the Nepomuk
mailing list