[Nepomuk] Review Request: Port the QueryService to the Query::ResultIterator
Simeon Bird
bladud at gmail.com
Sun Aug 5 06:08:58 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105872/
-----------------------------------------------------------
Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.
Description
-------
This is a fairly trivial patch to port the QueryService to the Query::ResultIterator; just doing something quick to get my hand in.
- Changes ResourceManager::mainModel() use in QueryService to ResourceIterator
- Removes now unneeded includes, functions, etc
- Speed up searchRunnable.run() by storing up to 10 results in the result list before sending them to folder.addResults(). This should be faster by needing less locking overhead. I haven't actually timed it, so it may be marginal.
This addresses bug 303383.
http://bugs.kde.org/show_bug.cgi?id=303383
Diffs
-----
services/queryservice/searchrunnable.h 1c12a9b
services/queryservice/searchrunnable.cpp 451db46
Diff: http://git.reviewboard.kde.org/r/105872/diff/
Testing
-------
Compiles, dolphin search still works.
Thanks,
Simeon Bird
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120805/63af3220/attachment.html>
More information about the Nepomuk
mailing list