[Nepomuk] Review Request: FileWatcher: Check the mtime of the file for CloseOnWrite events

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105839/#review16830
-----------------------------------------------------------



services/filewatch/nepomukfilewatch.cpp
<http://git.reviewboard.kde.org/r/105839/#comment13155>

    Nitpicking fun: in the spirit of readable diffs keep the original spaces. Oh, how I can be a PITA!



services/filewatch/nepomukfilewatch.cpp
<http://git.reviewboard.kde.org/r/105839/#comment13156>

    I just realized how this code could become much more compact:
    ask where { ?r nie:url <url> ; nie:lastModified "actualdate"^^xsd:dateTime . }.
    
    Just an idea. If that is too annoying just commit it. :)


- Sebastian Trueg


On Aug. 3, 2012, 2:29 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105839/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2012, 2:29 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     Tons of applications open files in 'write' mode even though they have no
>     intention of writing to them. When they close the file descriptor, it
>     produces a CloseOnWrite event and the FileWatcher service would add it
>     to the queue, and ask the fileindexer to index it.
> 
> 
> Diffs
> -----
> 
>   services/filewatch/nepomukfilewatch.cpp c998dc9 
> 
> Diff: http://git.reviewboard.kde.org/r/105839/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120803/906d6745/attachment-0001.html>