[Nepomuk] broken unittests

[Vishesh Handa]

Hey David

On Fri, Aug 3, 2012 at 5:56 PM, David Faure <faure at kde.org> wrote:

> All of the kdelibs unittest pass in 4.9 ... except for the nepomuk ones.
>
> The following tests FAILED:
>           1 - nepomuk-queryparsertest (Failed)
>           2 - nepomuk-querytest (Failed)
>           4 - nepomuk-resourcetest (Failed)
>           6 - nepomuk-dynamicresourcefacettest (Failed)
>
> I know

These tests are a pain to maintain cause they used to check the string
value of the queries. One of my commits broke them. I'm in the process of
writing new tests which actually runt the queries and test them properly.

ResourceTests: Around 3 tests fail, which I'm not sure how to fix right
now, but they are minor issues.

The first failure is:
>
> FAIL!  : QueryParserTest::testQueryParser(simple field query) Compared
> values
> are not the same
>    Actual (q): <?xml version="1.0"?><query limit="0" offset="0"
> fullTextScoring="false" fullTextScoringOrder="desc"
> flags=""><or><comparison
> property="http://www.semanticdesktop.org/ontologies/2007/11/01/pimo#hasTag
> "
> comparator=":" inverted="false"><literal
> datatype="http://www.w3.org/2001/XMLSchema#string
> ">nepomuk</literal></comparison><comparison
> property="http://www.semanticdesktop.org/ontologies/2007/08/15/nao#hasTag"
> comparator=":" inverted="false"><literal
> datatype="http://www.w3.org/2001/XMLSchema#string
> ">nepomuk</literal></comparison></or></query>
>
>    Expected (query): <?xml version="1.0"?><query limit="0" offset="0"
> fullTextScoring="false" fullTextScoringOrder="desc"
> flags=""><or><comparison
> property="onto:/hasTag" comparator=":" inverted="false"><literal
> datatype="http://www.w3.org/2001/XMLSchema#string
> ">nepomuk</literal></comparison><comparison
> property="onto:/tag" comparator=":" inverted="false"><literal
> datatype="http://www.w3.org/2001/XMLSchema#string">nepomuk</
>    Loc: [/d/kde/src/4/kdelibs/nepomuk/test/queryparsertest.cpp(153)]
>
> These two queries look *quite* different indeed. What happened?
>
> --
> David Faure, faure at kde.org, http://www.davidfaure.fr
> Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5
>
> _______________________________________________
> Nepomuk mailing list
> Nepomuk at kde.org
> https://mail.kde.org/mailman/listinfo/nepomuk
>



-- 
Vishesh Handa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120803/f10c40c8/attachment-0001.html>