[Nepomuk] Review Request: StorageService: Do not register the DBusInterface

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105833/#review16806
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Trueg


On Aug. 2, 2012, 9:14 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105833/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2012, 9:14 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     We do not need the /org/soprano/Server dbus interface. No one uses it,
>     and we land up spawning an extra thread for this dbus interface (Soprano
>     code)
>     
>     Additionally, they have been crashes when removing the dbus interface thread.
>     
>     BUG: 304452
>     FIXED-IN: 4.9.1
> 
> 
> This addresses bug 304452.
>     http://bugs.kde.org/show_bug.cgi?id=304452
> 
> 
> Diffs
> -----
> 
>   services/storage/storage.cpp 6cd4659 
> 
> Diff: http://git.reviewboard.kde.org/r/105833/diff/
> 
> 
> Testing
> -------
> 
> Yup.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120803/852b08aa/attachment.html>