[Nepomuk] Review Request: Resouce: Properly implement genericIcon

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105745/#review16743
-----------------------------------------------------------


This review has been submitted with commit 03a1dfa01084c84855c7120ec9c4bd10f401469f by Vishesh Handa to branch KDE/4.9.

- Commit Hook


On July 27, 2012, 3:31 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105745/
> -----------------------------------------------------------
> 
> (Updated July 27, 2012, 3:31 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     The old generic icon just used to look at the string present in
>     nao:hasSymbol. However, that was incorrect as nao:hasSymbol has a range
>     of nao:Symbol, and not of a string.
>     
>     This patch results in proper icons being shown in the Nepomuk KRunner,
>     as it uses genericIcon to get the icon name.
> 
> 
> Diffs
> -----
> 
>   nepomuk/core/resource.cpp eba3cea 
> 
> Diff: http://git.reviewboard.kde.org/r/105745/diff/
> 
> 
> Testing
> -------
> 
> Tested manually.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120801/ad1f5aae/attachment-0001.html>